[core] subscriber configuration #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
global Create/Destroy renamed to Start/Stop
rex-schilasky
changed the title
KerstinKeller
approved these changes
May 17, 2024
| @@ -96,6 +91,11 @@ namespace eCAL | |||
| return(m_created); | |||
| } | |||
|
|
|||
| bool CSubscriber::Create(const std::string& topic_name_) | |||
There was a problem hiding this comment.
@rex-schilasky why did you add this function?
| udp.enable = eCAL::Config::IsUdpMulticastRecEnabled(); | ||
|
|
||
| // tcp config | ||
| tcp.enable = eCAL::Config::IsTcpRecEnabled(); |
There was a problem hiding this comment.
I think this is a bit strange, because you give default values in ecal_subscriber_config.h but then in the constructor, assign the values from eCAL::Config.
We need to align with @Peguen but I agree maybe it makes sense that the eCAL::Config has a way to fill them with values from the Ini file...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void CPubGate::Create() | ||
| void CPubGate::Start() |
There was a problem hiding this comment.
warning: method 'Start' can be made static [readability-convert-member-functions-to-static]
ecal/core/src/pubsub/ecal_pubgate.h:43:
- void Start();
+ static void Start();| } | ||
|
|
||
| bool CSubscriber::Create(const std::string& topic_name_, const SDataTypeInformation& topic_info_) | ||
| bool CSubscriber::Create(const std::string& topic_name_, const SDataTypeInformation& data_type_info_, const Subscriber::Configuration& config_) |
There was a problem hiding this comment.
warning: parameter 'config_' is unused [misc-unused-parameters]
Suggested change
| bool CSubscriber::Create(const std::string& topic_name_, const SDataTypeInformation& data_type_info_, const Subscriber::Configuration& config_) | |
| bool CSubscriber::Create(const std::string& topic_name_, const SDataTypeInformation& data_type_info_, const Subscriber::Configuration& /*config_*/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSubscriber configuration introduced.